Make Plan build on Windows
ClosedPublic

Authored by leinir on Dec 8 2017, 1:29 PM.

Details

Summary

QPair should not be used as a base class for exported things,
see also https://bugreports.qt.io/browse/QTBUG-49658
Some assumed std functions are just gcc things and not readily available in MSVC
Some exports don't work right with MSVC, also fixed

Test Plan

Without patch: Does not build on Windows

With patch: Builds and runs on Windows

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir requested review of this revision.Dec 8 2017, 1:29 PM
leinir created this revision.
danders accepted this revision.Dec 8 2017, 6:39 PM

Surprised it was *that* easy...

This revision is now accepted and ready to land.Dec 8 2017, 6:39 PM
This revision was automatically updated to reflect the committed changes.