forward socket error string to KTcpSocket
ClosedPublic

Authored by mkoller on Dec 8 2017, 12:46 PM.

Details

Summary

KTcpSocket is a QIODevice, internally using a Qt socket - however it does not set the error string of itself when the internal socket signals some error condition.

The original problem I had with this was the PIM maildispatcher - in the lack of any error string - just showing an error number when notifying the user. But a "Failed to transport message. 3" does not really say much to the user.

Now at least I get "Failed to transport message. Host not found"

Test Plan

using maildispatcher sending mail to an unknown host

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkoller created this revision.Dec 8 2017, 12:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 8 2017, 12:46 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
mkoller requested review of this revision.Dec 8 2017, 12:46 PM
dfaure accepted this revision.Dec 8 2017, 1:16 PM
This revision is now accepted and ready to land.Dec 8 2017, 1:16 PM
This revision was automatically updated to reflect the committed changes.