Differential D9176

use the new Package::fileUrl to load from resources
ClosedPublic
Actions

Authored by mart on Dec 4 2017, 4:16 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R120:aa53860409ac: use the new Package::fileUrl to load from resources

Summary

QUrl::fromLocalFile can't be used when packages are qrc

Test Plan

plasashell loads correctly with packages from qrc

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mart created this revision.Dec 4 2017, 4:16 PM

Restricted Application added a project: Plasma. · View Herald TranscriptDec 4 2017, 4:16 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart requested review of this revision.Dec 4 2017, 4:16 PM

mart added a reviewer: Plasma.Dec 4 2017, 5:03 PM

davidedmundson accepted this revision.Dec 4 2017, 5:05 PM

This revision is now accepted and ready to land.Dec 4 2017, 5:05 PM

Closed by commit R120:aa53860409ac: use the new Package::fileUrl to load from resources (authored by mart). · Explain WhyDec 4 2017, 5:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			krunner/view.cpp (2 lines)
M			shell/containmentconfigview.cpp (2 lines)
M			shell/desktopview.cpp (4 lines)
M			shell/osd.h (3 lines)
M			shell/osd.cpp (8 lines)
M			shell/panelconfigview.cpp (2 lines)
M			shell/panelview.cpp (2 lines)
M			shell/shellcorona.cpp (8 lines)

Diff 23452

krunner/view.cpp

Loading...

shell/containmentconfigview.cpp

Loading...

shell/desktopview.cpp

Loading...

shell/osd.h

Loading...

shell/osd.cpp

Loading...

shell/panelconfigview.cpp

Loading...

shell/panelview.cpp

Loading...

shell/shellcorona.cpp

Loading...