Remove double lookups
ClosedPublic

Authored by mlaurent on Dec 4 2017, 12:14 PM.

Diff Detail

Repository
R301 KEmoticons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Dec 4 2017, 12:14 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 4 2017, 12:14 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
mlaurent requested review of this revision.Dec 4 2017, 12:14 PM
dfaure accepted this revision.Dec 4 2017, 12:36 PM

I expect this map to be very small, and creating a null KEmoticonsTheme allocates a d pointer, so I'm not 100% sure this is faster.

But OK, I'm allergic to double lookups and people tend to reuse constructs they saw, so I still prefer the code after the change than before ;)

This revision is now accepted and ready to land.Dec 4 2017, 12:36 PM
This revision was automatically updated to reflect the committed changes.