Differential D9122

Implement QQmlParserStatus in FolderModel
ClosedPublic
Actions

Authored by hein on Dec 3 2017, 11:36 AM.

Details

Reviewers

broulik

Group Reviewers

Plasma

Commits

R119:1a45aaf94893: Implement QQmlParserStatus in FolderModel

Summary

This saves four calls to invalidateFilter() during startup with
default config. With non-default config it will save various
calls to invalidate() and invalidateFilter() more.

Test Plan

Tests pass with adjustments.

Diff Detail

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hein created this revision.Dec 3 2017, 11:36 AM

Restricted Application added a project: Plasma. · View Herald TranscriptDec 3 2017, 11:36 AM

hein requested review of this revision.Dec 3 2017, 11:36 AM

Remove a stray qDebug line.

containments/desktop/plugins/folder/foldermodel.h
79–80	Add `Q_INTERFACES(QQmlParserStatus)`

Add interface

Closed by commit R119:1a45aaf94893: Implement QQmlParserStatus in FolderModel (authored by hein). · Explain WhyDec 3 2017, 5:53 PM

This revision was automatically updated to reflect the committed changes.

I accidentally pushed this, but given Kai's earlier comment I think this was OK. Please double-check if necessary.

It's not my day with command line tools I think :-)

Revision Contents
Changeset List

			Path	Packages
M			containments/desktop/plugins/folder/autotests/foldermodeltest.cpp (12 lines)
M			containments/desktop/plugins/folder/autotests/positionertest.cpp (4 lines)
M			containments/desktop/plugins/folder/foldermodel.h (10 lines)
M			containments/desktop/plugins/folder/foldermodel.cpp (49 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23320	77ea0ec		Dec 3 2017, 11:36 AM	★	★
Diff 2	23321	77ea0ec	Remove a stray qDebug line.	Dec 3 2017, 11:40 AM	★	★
Diff 3	23323	77ea0ec	Add interface	Dec 3 2017, 11:49 AM	★	★
Diff 4	23385	fbbdafa	R119:1a45aaf9489303f1f82fabfe0bca1a351ccdc4ef	Dec 3 2017, 3:11 PM	★	★