Differential D9084

Simplify MPRIS callback code
ClosedPublic
Actions

Authored by mtijink on Dec 1 2017, 11:18 AM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:147d8510d51a: Simplify MPRIS callback code
Summary

Makes sure the MPRIS data is always up-to-date, so requesting updates
separately is never necessary. Also provides a way to remove callbacks.

Test Plan

All information still appears in the MPRIS activity and the controls still work.

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mtijink requested review of this revision.Dec 1 2017, 11:18 AM
mtijink created this revision.
albertvaka accepted this revision.Dec 7 2017, 4:51 PM
This revision is now accepted and ready to land.Dec 7 2017, 4:51 PM
Closed by commit R225:147d8510d51a: Simplify MPRIS callback code (authored by mtijink, committed by albertvaka). · Explain WhyDec 7 2017, 4:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23620

View Options

src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java

Loading...