Differential D9057

Fixing File Filters
ClosedPublic
Actions

Authored by narvaez on Nov 29 2017, 7:37 PM.

Details

Reviewers
apol
aspotashev
Group Reviewers
KDE Edu
Commits
R331:abe652b5231e: Fixing File Filters
Summary

BUG: 386856

Diff Detail

Repository
R331 Kig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
narvaez created this revision.Nov 29 2017, 7:37 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 29 2017, 7:37 PM
narvaez requested review of this revision.Nov 29 2017, 7:37 PM
apol accepted this revision.Nov 29 2017, 7:44 PM
apol added a subscriber: apol.

Please next time use a more descriptive commit message. ;)

This revision is now accepted and ready to land.Nov 29 2017, 7:44 PM
narvaez added a comment.Nov 29 2017, 8:02 PM
In D9057#173505, @apol wrote:

Please next time use a more descriptive commit message. ;)

Yes, sorry, I really rushed this review in order to ask for an i18n exception.

apol added a comment.Feb 20 2018, 2:37 PM

Please land?

aspotashev accepted this revision.Feb 20 2018, 4:19 PM

LGTM. Didn't check if these are all necessary changes.

Closed by commit R331:abe652b5231e: Fixing File Filters (authored by narvaez). · Explain WhyMar 6 2018, 2:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28837

View Options

filters/asyexporter.cc

Loading...
View Options

filters/latexexporter.cc

Loading...
View Options

filters/svgexporter.cc

Loading...
View Options

filters/xfigexporter.cc

Loading...
View Options

kig/kig_part.cpp

Loading...
View Options

modes/typesdialog.cpp

Loading...