Differential D9044

Fix compile with QT_NO_CAST_FROM_ASCII
ClosedPublic
Actions

Authored by mlaurent on Nov 29 2017, 5:34 AM.

Tags

Subscribers

Details

Reviewers

Commits

R309:03d24088ea68: Fix compile with QT_NO_CAST_FROM_ASCII

Test Plan

Compile it

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mlaurent created this revision.Nov 29 2017, 5:34 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptNov 29 2017, 5:34 AM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

mlaurent requested review of this revision.Nov 29 2017, 5:34 AM

mlaurent added a reviewer: dfaure.Nov 29 2017, 5:34 AM

dfaure requested changes to this revision.Nov 29 2017, 6:41 AM

dfaure added inline comments.

src/sycoca/kbuildservicegroupfactory.cpp
84	Use QLatin1String for comparisons
src/sycoca/kbuildsycoca.cpp
248	`fromLatin1` would do, it's ascii strings like "services" etc.
302	same
src/sycoca/kmimeassociations.cpp
110	startsWith() has a QLatin1String overload

This revision now requires changes to proceed.Nov 29 2017, 6:41 AM

mlaurent added inline comments.Nov 29 2017, 7:08 AM

src/sycoca/kbuildsycoca.cpp
248	Yep I was not sure about this one. It confirms that this one was incorrect. I will fix all soon.

Fix error found by David

dfaure accepted this revision.Nov 30 2017, 6:20 AM

This revision is now accepted and ready to land.Nov 30 2017, 6:20 AM

Closed by commit R309:03d24088ea68: Fix compile with QT_NO_CAST_FROM_ASCII (authored by mlaurent). · Explain WhyNov 30 2017, 6:29 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (3 lines)
M			src/sycoca/kbuildmimetypefactory.cpp (4 lines)
M			src/sycoca/kbuildservicefactory.cpp (2 lines)
M			src/sycoca/kbuildservicegroupfactory.cpp (8 lines)
M			src/sycoca/kbuildservicetypefactory.cpp (4 lines)
M			src/sycoca/kbuildsycoca.cpp (22 lines)
M			src/sycoca/kctimefactory.cpp (2 lines)
M			src/sycoca/kmimeassociations.cpp (4 lines)
M			src/sycoca/ksycoca.cpp (12 lines)
M			src/sycoca/vfolder_menu.cpp (40 lines)

Diff 23160

CMakeLists.txt

Loading...

src/sycoca/kbuildmimetypefactory.cpp

Loading...

src/sycoca/kbuildservicefactory.cpp

Loading...

src/sycoca/kbuildservicegroupfactory.cpp

Loading...

src/sycoca/kbuildservicetypefactory.cpp

Loading...

src/sycoca/kbuildsycoca.cpp

Loading...

src/sycoca/kctimefactory.cpp

Loading...

src/sycoca/kmimeassociations.cpp

Loading...

src/sycoca/ksycoca.cpp

Loading...

src/sycoca/vfolder_menu.cpp

Loading...