Fix obvious porting error, allDay was ignored.
ClosedPublic
Actions

Authored by dfaure on Nov 25 2017, 12:45 PM.

Details

Reviewers

Commits

Summary

Commit df84459e7 contained:

+ todo->setAllDay(false);

Added a unittest for todos with date-only start/end/due dates,
just like zanshin does. This test file would have caught this porting
bug.

Tested with libical-1.0.1 only.

Test Plan

Unittest + zanshin

Repository

R172 KCalendar Core

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.Nov 25 2017, 12:45 PM

Thanks!

This revision is now accepted and ready to land.Nov 26 2017, 8:08 AM

This revision was automatically updated to reflect the committed changes.

		Path
A	M	autotests/data/Compat-libical3/Todos.ics (29 lines)
A	M	autotests/data/Compat-libical3/Todos.ics.ical.ref (28 lines)
A	M	autotests/data/Compat/Todos.ics (29 lines)
A	M	autotests/data/Compat/Todos.ics.ical.ref (28 lines)
M		src/icalformat_p.cpp (2 lines)