[Widget Explorer] Become transparent during widget drag
ClosedPublic

Authored by broulik on Feb 3 2016, 10:04 PM.

Details

Summary

This makes the Widget Explorer fade and become transparent for mouse events while dragging a widget. This allows to place widgets directly behind the Widget Explorer.

Drive-by fix to use a declarative approach for preventWindowHide.

BUG: 352527

Test Plan

Video: https://www.youtube.com/watch?v=tmDdmQ-pEAQ

Not too happy with the transparency stuff, especially not that it happens as soon as I start dragging. Another approach I could imagine is widget explorer moving out of the way when I hover it and then moving it back in but for that I would need a C++ plugin and probably X stuff. (Don't we have a Usability group in Phab?)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 2182.Feb 3 2016, 10:04 PM
broulik retitled this revision from to [Widget Explorer] Become transparent during widget drag.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a project: Plasma.
mart accepted this revision.Feb 9 2016, 10:18 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Feb 9 2016, 10:18 AM
colomar added a subscriber: colomar.Feb 9 2016, 4:10 PM

This patch is okay as a stop-gap solution, but the alternative approach you suggest would be much better from a UX perspective.
So I'd give my okay for this, with the attached string that I'd strongly suggest to explore the other approach next.

This revision was automatically updated to reflect the committed changes.