Differential D8961

[Folder View] Accept mouse events if we handled them
ClosedPublic
Actions

Authored by broulik on Nov 23 2017, 10:09 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:0d3f000f5bfe: [Folder View] Accept mouse events if we handled them
Summary

This keeps the event from propagating to e.g. the containment resulting in two context menus (both Folder View's item context menu and the containment action) opening at once.

BUG: 387199
FIXED-IN: 5.12.0

Test Plan

Requires e2795e9472333d5e8b2ce70017ca705474ebe3d2 in kdeclarative

  • I no longer get two context menus when right-clicking in Qt 5.10
  • Back mouse button still goes back in panel Folder View

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Nov 23 2017, 10:09 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 23 2017, 10:09 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Nov 23 2017, 10:10 AM
hein accepted this revision.Nov 24 2017, 9:01 AM
This revision is now accepted and ready to land.Nov 24 2017, 9:01 AM
Closed by commit R119:0d3f000f5bfe: [Folder View] Accept mouse events if we handled them (authored by broulik). · Explain WhyNov 24 2017, 9:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22875

View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...