Differential D8874

Update AtCore Recipe Update recipe to fit the new context of the binary factory, also added a new tag to the stable branch
ClosedPublic
Actions

Authored by laysrodrigues on Nov 17 2017, 9:22 PM.

Details

Reviewers
vonreth
kfunk
Commits
R877:212eed6c46ad: Update AtCore Recipe
Summary

Signed-off-by: Lays Rodrigues <lays.silva@tvglobo.com.br>

Diff Detail

Repository
R877 Craft Blueprints for KDE
Branch
arcpatch-D8874
Lint
No Linters Available
Unit
No Unit Test Coverage
laysrodrigues created this revision.Nov 17 2017, 9:22 PM
vonreth added inline comments.Nov 17 2017, 10:52 PM
extragear/atcore/atcore.py
0

Not sure what that is

29

Defining an exe name is still ok it should just match

31

Just remove the define to use the default

vonreth requested changes to this revision.Nov 17 2017, 10:52 PM
This revision now requires changes to proceed.Nov 17 2017, 10:52 PM
laysrodrigues added inline comments.Nov 18 2017, 1:18 PM
extragear/atcore/atcore.py
0

Sorry, my bad on editing the file xD

laysrodrigues updated this revision to Diff 22569.Nov 18 2017, 1:20 PM

Fix the points that Hannah pointed out

Updating D8874: Update AtCore Recipe

Update recipe to fit the new context of the binary factory,
also added a new tag to the stable branch

vonreth accepted this revision.Nov 18 2017, 10:15 PM
This revision is now accepted and ready to land.Nov 18 2017, 10:15 PM
laysrodrigues closed this revision.Jan 4 2018, 1:58 PM

Revision Contents
Changeset List

PathPackages
Mextragear/atcore/atcore.py (9 lines)

Diff 22569

View Options

extragear/atcore/atcore.py

Loading...