push changes from MessageViewer to kdepim (Viewer::UpdateMode -> UpdateMode).
ClosedPublic
Actions

Authored by knauss on Jan 29 2016, 6:22 PM.

Details

Reviewers

Maniphest Tasks

T1223: split objecttreeparer out of messageviewer

Commits

Repository

R43 KDE PIM

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

knauss retitled this revision from to push changes from MessageViewer to kdepim (Viewer::UpdateMode -> UpdateMode)..

knauss updated this object.

knauss edited the test plan for this revision. (Show Details)

knauss added a reviewer: mlaurent.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

plugins/messageviewer/bodypartformatter/calendar/text_calendar.cpp
235–236	SLOT ?

change SLOT->SIGNAL

plugins/messageviewer/bodypartformatter/calendar/text_calendar.cpp
235–237	is there any way to use the new SIGNAL-SLOT syntax here? asyncResultObserver is only a QObject Pointer, so it refuses to

Using now enums.h

I don't see diff where you add enum.h in messageviewer ?
Which is the phabricator review ?

plugins/messageviewer/bodypartformatter/calendar/text_calendar.cpp
235–237 ↗	(On Diff #2162)	it's not possible indeed to use new connect api here

In D886#17260, @mlaurent wrote:

I don't see diff where you add enum.h in messageviewer ?
Which is the phabricator review ?

phab is a litle bit stupid. it is a already accepted request: D871

Seems ok ship it

This revision is now accepted and ready to land.Feb 3 2016, 5:51 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (2 lines)
M			kmail/kmreadermainwin.cpp (2 lines)
M			kmail/kmreaderwin.h (2 lines)
M			kmail/kmreaderwin.cpp (6 lines)
M			plugins/messageviewer/bodypartformatter/calendar/memorycalendarmemento.h (7 lines)
M			plugins/messageviewer/bodypartformatter/calendar/memorycalendarmemento.cpp (4 lines)
M			plugins/messageviewer/bodypartformatter/calendar/text_calendar.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2143	b825af1		Jan 29 2016, 6:22 PM	★	★
Diff 2	2157	1af4bde	change SLOT->SIGNAL	Jan 31 2016, 7:03 PM	★	★
Diff 3	2162	9912f4e	Using now enums.h	Feb 1 2016, 3:39 PM	★	★
Diff 4	2180	bab004b	rKDEPIMf307f16d7578cd38a5557c1593272c842e328279	Feb 3 2016, 5:38 PM	★	★