Differential D8860

Modifications to piano_composition
AbandonedPublic
Actions

Authored by rohitdas on Nov 17 2017, 11:11 AM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris
GCompris: Improvements
Summary

Please apply all changes in the playpiano branch of GCompris-QT.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
rohitdas created this revision.Nov 17 2017, 11:11 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 17 2017, 11:11 AM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
jjazeix requested changes to this revision.Nov 17 2017, 12:24 PM

it is better to let it as before (we do this for all activities), we don't gain anything in readability and in performance

This revision now requires changes to proceed.Nov 17 2017, 12:24 PM
rohitdas abandoned this revision.Nov 18 2017, 2:23 PM

Revision Contents
Changeset List

Diff 22506

View Options

src/activities/piano_composition/piano_composition.js

Loading...