Add support for new IdleInhibition protocol
ClosedPublic
Actions

Authored by graesslin on Nov 16 2017, 8:51 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:ff2e8834694a: Add support for new IdleInhibition protocol

Summary

A small helper class is added which manages inhibiting idle for the
ShellClients. So far only very basic functionality is added. That is
only the inhibition on the Surface is followed. It is not yet checked
whether the ShellClient is visible at all. That needs some changes in
ShellClient.

BUG: 385956
FIXED-IN: 5.12

Test Plan

New test case passes

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Nov 16 2017, 8:51 PM

Restricted Application added a project: KWin. · View Herald TranscriptNov 16 2017, 8:51 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

davidedmundson accepted this revision.Nov 30 2017, 8:32 AM

davidedmundson added a subscriber: davidedmundson.

davidedmundson added inline comments.

idle_inhibition.cpp
43	We could do with a line in wayland-protocol docs to say it has to be a toplevel surface. Right now we're making an assumption. Albeit a fairly safe one.

This revision is now accepted and ready to land.Nov 30 2017, 8:32 AM

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptNov 30 2017, 8:32 AM

Closed by commit R108:ff2e8834694a: Add support for new IdleInhibition protocol (authored by graesslin). · Explain WhyNov 30 2017, 8:51 PM

This revision was automatically updated to reflect the committed changes.

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptNov 30 2017, 8:51 PM

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (3 lines)
M		autotests/integration/CMakeLists.txt (1 line)
A	M	autotests/integration/idle_inhibition_test.cpp (129 lines)
M		autotests/integration/kwin_wayland_test.h (5 lines)
M		autotests/integration/test_helpers.cpp (16 lines)
A	M	idle_inhibition.h (64 lines)
A	M	idle_inhibition.cpp (80 lines)
M		wayland_server.cpp (8 lines)