Differential D8835

core, documented ScoreItem.qml
ClosedPublic
Actions

Authored by asagtani on Nov 16 2017, 9:28 AM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
asagtani created this revision.Nov 16 2017, 9:28 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 16 2017, 9:28 AM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
jjazeix added a subscriber: jjazeix.Nov 23 2017, 12:44 PM
jjazeix added inline comments.
src/core/ScoreItem.qml
29

no need of "usually", it is always the case

101

it's when the player turn ends not necessary when the other player needs to start

asagtani updated this revision to Diff 22821.Nov 23 2017, 1:23 PM
jjazeix accepted this revision.Nov 24 2017, 9:19 PM
This revision is now accepted and ready to land.Nov 24 2017, 9:19 PM
jjazeix closed this revision.Nov 24 2017, 9:22 PM

commited in https://cgit.kde.org/gcompris.git/commit/?id=1420e35ee356c01d95ccb6220c91d799f1c098c9

You full diff does not contain all the change (just the latest, I merged them manually).

I made a mistake with the author commit (I put myself instead of your name).

Thank you for the change.

Revision Contents
Changeset List

PathPackages
Msrc/core/ScoreItem.qml (4 lines)

Diff 22821

View Options

src/core/ScoreItem.qml

Loading...