Differential D8819

Only notify if the property changes
ClosedPublic
Actions

Authored by apol on Nov 14 2017, 2:05 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:02c3c22c76ae: Only notify if the property changes

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Nov 14 2017, 2:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 14 2017, 2:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested changes to this revision.Nov 14 2017, 2:22 PM
davidedmundson added a subscriber: davidedmundson.

Concept is fine.
I think you have a typo in the last method.

applets/notifications/lib/notificationsapplet.cpp
137

you're not updating m_popupPosition

This revision now requires changes to proceed.Nov 14 2017, 2:22 PM
davidedmundson accepted this revision.Nov 14 2017, 2:40 PM
This revision is now accepted and ready to land.Nov 14 2017, 2:40 PM
Closed by commit R120:02c3c22c76ae: Only notify if the property changes (authored by apol). · Explain WhyNov 14 2017, 4:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22361

View Options

applets/notifications/lib/notificationsapplet.cpp

Loading...