| tbaumgart |
The root cause for this issue is that finance.yahoo.com web price qoute
source has been discontinued and is replaced with this commit by
finance.google.com providing the source name 'Google Finance' and also
'Yahoo Currency' to restore online price update support, which is internal
bound to the latter name.
BUG:386462
FIXED-IN:4.8.2
tested in 4.8 branch by running 'update online price'
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Fixed in a bit different way in master. See Git repo for details. So this change is superfluous.
Your commit could not be backported because of multiple merge conflicts. It is required to recreate a new patch from your commit or to apply my initial commit to 4.8 - please choose.
Yes, simply backporting does not work anymore, because in master the webpricequote ctor has two new parameters which are not present in 4.8. I suggest to recreate the patch.
Your patch seems not to be complete - there are still references to finance.yahoo.com - see https://cgit.kde.org/kmymoney.git/tree/kmymoney/converter/webpricequote.cpp#n762
I disagree: this part only converts an old format to a new one. This only happens in case the data is present on the system KMyMoney is installed on. If it is not there, nothing regarding the old source Yahoo will be done. I don't know what happens if the old format entry remains as it is so I left that part of the code as it is.