Differential D8676

bad textarea width for rename file if filename too short
AbandonedPublic
Actions

Authored by hein on Nov 6 2017, 7:22 AM.

Details

Reviewers
painlessroaster
Summary

BUG: 386546

plasma-desktop - bad textarea width in rename file

steps for replicate:

  • create file (on plasma-destkop) with filename 't1'
  • try rename file to: 't1 test test'

corrupted from commit:

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
painlessroaster created this revision.Nov 6 2017, 7:22 AM
hein added a subscriber: hein.Nov 6 2017, 8:52 AM

The original commit fixed broken RTL support. Did you test that this works with RTL? Because from a quick look it looks like you just reverted the code to its old, broken state.

painlessroaster added a comment.Nov 6 2017, 1:38 PM

Where is RTL support in original code? It is only set default width and x position of textarea.

hein added a comment.Nov 6 2017, 1:41 PM

Did you read the Phabricator ticket referenced in the original commit?

painlessroaster added a comment.Nov 6 2017, 3:04 PM

Yes, thank you. I will try to fix your bad code with the scrollbar position on the left (for gridView.effectiveLayoutDirection == Qt.RightToLeft).

hein added a comment.Nov 6 2017, 3:14 PM

And you just lost any chance of me accepting your patch, cf. https://www.kde.org/code-of-conduct/

hein commandeered this revision.Nov 6 2017, 3:14 PM
hein abandoned this revision.
hein added a reviewer: painlessroaster.
davidedmundson added a subscriber: davidedmundson.Dec 23 2017, 10:23 PM

@painlessroaster did you manage to make another patch that fixed your bug but with working RTL?

Revision Contents
Changeset List

Diff 21950

View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...