Differential D8647

Create d-pointer for KNewLoanWizard
ClosedPublic
Actions

Authored by wojnilowicz on Nov 4 2017, 6:04 AM.

Tags

Subscribers

tbaumgart, KMyMoney

Details

Reviewers

Group Reviewers

Commits

R261:f9e64823f72b: Create d-pointer for KNewLoanWizard

Test Plan

Created new lo and then edited it.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wojnilowicz created this revision.Nov 4 2017, 6:04 AM

Looks good to me

kmymoney/wizards/newloanwizard/keditloanwizard.cpp
58	Are the two lines above not needed, then they should be removed.

Corrected commented code.

wojnilowicz marked an inline comment as done.Nov 4 2017, 9:40 AM

tbaumgart accepted this revision as: tbaumgart.Nov 5 2017, 7:23 AM

This revision is now accepted and ready to land.Nov 5 2017, 7:23 AM

Closed by commit R261:f9e64823f72b: Create d-pointer for KNewLoanWizard (authored by wojnilowicz). · Explain WhyNov 5 2017, 1:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kmymoney/wizards/newloanwizard/CMakeLists.txt (4 lines)
M			kmymoney/wizards/newloanwizard/additionalfeeswizardpage.cpp (11 lines)
M			kmymoney/wizards/newloanwizard/effectivedatewizardpage.cpp (1 line)
M			kmymoney/wizards/newloanwizard/interestcategorywizardpage.cpp (4 lines)
M			kmymoney/wizards/newloanwizard/keditloanwizard.h (13 lines)
M			kmymoney/wizards/newloanwizard/keditloanwizard.cpp (300 lines)
M			kmymoney/wizards/newloanwizard/knewloanwizard.h (56 lines)
M			kmymoney/wizards/newloanwizard/knewloanwizard.cpp (535 lines)
V			kmymoney/wizards/newloanwizard/{knewloanwizard.ui ← knewloanwizarddecl.ui} (4 lines)
A	M		kmymoney/wizards/newloanwizard/knewloanwizard_p.h (529 lines)
V			kmymoney/wizards/newloanwizard/{knewloanwizarddecl.ui → knewloanwizard.ui}

Diff 21911

kmymoney/wizards/newloanwizard/CMakeLists.txt

Loading...

kmymoney/wizards/newloanwizard/additionalfeeswizardpage.cpp

Loading...

kmymoney/wizards/newloanwizard/effectivedatewizardpage.cpp

Loading...

kmymoney/wizards/newloanwizard/interestcategorywizardpage.cpp

Loading...

kmymoney/wizards/newloanwizard/keditloanwizard.h

Loading...

kmymoney/wizards/newloanwizard/keditloanwizard.cpp

Loading...

kmymoney/wizards/newloanwizard/knewloanwizard.h

Loading...

kmymoney/wizards/newloanwizard/knewloanwizard.cpp

Loading...

kmymoney/wizards/newloanwizard/knewloanwizard.ui

Loading...

kmymoney/wizards/newloanwizard/knewloanwizard_p.h

Loading...

kmymoney/wizards/newloanwizard/knewloanwizarddecl.ui

Loading...