Differential D8616

[System Tray] Sort Entries by name
ClosedPublic
Actions

Authored by broulik on Nov 2 2017, 1:11 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:0eb06ad874ae: [System Tray] Sort Entries by name
Test Plan

Changing visibility still works. Assigning a shortcut still works.

However, something's quite funky in the dialog, causing crashes and sometimes showing up empty but I think that's the shared engine bug we have with Qt 5.9/5.10?

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Nov 2 2017, 1:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 2 2017, 1:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added a subscriber: davidedmundson.Nov 2 2017, 1:25 PM

There is a bug that I know of in < 5.9.2 if you have a crash after I want to know about it.

applets/systemtray/package/contents/ui/ConfigEntries.qml
95

return a .localeCompare(b)

broulik updated this revision to Diff 21772.Nov 2 2017, 1:35 PM
  • Use localeCompare, also fixes "vlc" showing up last just because it starts lowercase
davidedmundson accepted this revision.Nov 2 2017, 1:49 PM
This revision is now accepted and ready to land.Nov 2 2017, 1:49 PM
Closed by commit R120:0eb06ad874ae: [System Tray] Sort Entries by name (authored by broulik). · Explain WhyNov 2 2017, 1:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21773

View Options

applets/systemtray/package/contents/ui/ConfigEntries.qml

Loading...