Revert code completion changes
ClosedPublic
Actions

Authored by kfunk on Jan 25 2016, 8:43 AM.

Details

Reviewers

mwolff
olivierjg

Commits

R32:090226357608: Revert code completion changes
R33:090226357608: Revert code completion changes

Summary

This re-applies the following reverts in bulk:

3c22033 - Revert "Add assistants to the "argument hints" code completion" (3 months ago) <Milian Wolff>
eebb47f - Revert "Remove assistant popup" (3 months ago) <Milian Wolff>
9cbe01a - Revert "Move assistant completion to its own KTextEditor::CompletionModel" (3 months ago) <Milian Wolff>

As discussed on the mailing list:

https://mail.kde.org/pipermail/kdevelop-devel/2016-January/052737.html

Diff Detail

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kfunk updated this revision to Diff 2086.Jan 25 2016, 8:43 AM

kfunk retitled this revision from to Revert code completion changes.

kfunk updated this object.

kfunk edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 25 2016, 8:43 AM

kfunk added reviewers: mwolff, olivierjg.Jan 25 2016, 9:05 AM

Good riddance to bad rubbish.

This revision is now accepted and ready to land.Jan 25 2016, 9:36 AM

imo, if this reduces the diff against 5.0 branch, then I'm all for it. Could you double check it? Should be relatively easy to spot whether anything else is missing that way.

Closed by commit R33:090226357608: Revert code completion changes (authored by kfunk). · Explain WhyJan 25 2016, 9:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		interfaces/iuicontroller.h (10 lines)
D	M	language/assistant/assistantcompletionmodel.h (55 lines)
D	M	language/assistant/assistantcompletionmodel.cpp (90 lines)
M		language/assistant/staticassistantsmanager.h (3 lines)
M		language/assistant/staticassistantsmanager.cpp (81 lines)
A	M	shell/AssistantButton.qml (101 lines)
M		shell/CMakeLists.txt (8 lines)
A	M	shell/assistantpopup.h (134 lines)
A	M	shell/assistantpopup.cpp (380 lines)
A	M	shell/assistantpopup.qml (89 lines)
M		shell/uicontroller.h (4 lines)
M		shell/uicontroller.cpp (32 lines)