Cleanup QTimer in KisSignalCompressor
AbandonedPublic

Authored by poke1024 on Oct 25 2017, 7:34 PM.

Details

Reviewers
dkazakov
Group Reviewers
Krita
Summary

I believe there's a delete missing here.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
poke1024 created this revision.Oct 25 2017, 7:34 PM
rempt added a subscriber: rempt.Oct 25 2017, 8:02 PM

Hm... Perhaps not -- though it's possible I'm missing something -- but the timer is created like this:

, m_timer(new QTimer(this))

Which means that it will get deleted whenever the signal compressor is deleted, since that's the timer's parent.

dkazakov requested changes to this revision.Oct 26 2017, 12:49 PM
dkazakov added a subscriber: dkazakov.

Yes, the timer is a part of QObject hierarchy and is deleted by its parent, that is ​KisSignalCompressor

This revision now requires changes to proceed.Oct 26 2017, 12:49 PM
poke1024 abandoned this revision.Oct 28 2017, 3:55 PM

Ok, I was lacking understanding of QT QObject hierarchies.