Differential D8476

qPort to new connect api + use const'ref
ClosedPublic
Actions

Authored by mlaurent on Oct 25 2017, 3:01 PM.

Details

Reviewers
hein
Commits
R119:b706bc73fa63: qPort to new connect api + use const'ref

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Oct 25 2017, 3:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 25 2017, 3:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Oct 25 2017, 3:05 PM
broulik added inline comments.
containments/desktop/plugins/folder/foldermodel.h
256

Did you check whether QML can cope with const &? The urls is used in an onMove QML handler (I recall it not handling const * well)

mlaurent added inline comments.Oct 25 2017, 4:19 PM
containments/desktop/plugins/folder/foldermodel.h
256

I didn't see an error here, but perhaps I didn't test action which use this signal.
To be safe I will exclude this part of patch until I am sure that it's ok.

mlaurent updated this revision to Diff 21324.Oct 25 2017, 4:21 PM
  • Perhaps that qml doesn't support const QUrl &
hein accepted this revision.Oct 26 2017, 8:50 AM
This revision is now accepted and ready to land.Oct 26 2017, 8:50 AM
Closed by commit R119:b706bc73fa63: qPort to new connect api + use const'ref (authored by mlaurent). · Explain WhyOct 26 2017, 9:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 21357

View Options

containments/desktop/plugins/folder/foldermodel.h

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...