Differential D8461

Remove unused config.h.cmake entries
ClosedPublic
Actions

Authored by davidk on Oct 25 2017, 4:22 AM.

Details

Reviewers
dfaure
Commits
R293:d636fdc569ea: Remove unused config.h.cmake entries
Summary

I'm not sure why they were introduced, but they aren't used anywhere in the
code.

Test Plan
  • "grep -r HAVE_MALLOC_H baloo"
      • "grep -r HAVE_MALLOC_TRIM baloo"
    • Compiles.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidk created this revision.Oct 25 2017, 4:22 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 25 2017, 4:22 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
davidk updated this revision to Diff 21277.Oct 25 2017, 4:25 AM

Fix commit message.

dfaure accepted this revision.Nov 5 2017, 9:11 PM
dfaure added a subscriber: dfaure.

The answer to "I'm not sure why" is easy: git log -S MALLOC shows exactly two commits, the one that introduced the usage of this stuff, and the one that removed it again. Ain't git great?

BTW, I see more dead code, like baloo_removexattr, baloo_getxattr and then apparently baloo_setxattr is only used by unittests.

This revision is now accepted and ready to land.Nov 5 2017, 9:11 PM
davidk added a comment.Nov 9 2017, 8:43 AM

Thanks for the git hint and the revew.
Then we should remove this code too.

davidk updated this revision to Diff 22171.Nov 11 2017, 5:30 AM

Improve commit message

Closed by commit R293:d636fdc569ea: Remove unused config.h.cmake entries (authored by davidk). · Explain WhyNov 11 2017, 5:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MConfigureChecks.cmake (3 lines)
Mconfig.h.cmake (7 lines)

Diff 22172

View Options

ConfigureChecks.cmake

Loading...
View Options

config.h.cmake

Loading...