Differential D843

Refactor timer plasmoid
ClosedPublic
Actions

Authored by abrahams on Jan 20 2016, 4:25 AM.

Details

Reviewers

mart

Group Reviewers

Plasma

Commits

R114:10c489b6b90b: Refactor timer plasmoid

Summary

This splits the timer plasmoid into main.qml and TimerView.qml. The
main difference is that the plasmoid can define compactRepresentation.

BUG: 353090

Diff Detail

Repository

R114 Plasma Addons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Update copyright year

This is my first attempt at writing QML. I was not sure of how to idiomatically call methods in the TimerView subobject from the Main.qml Plasmoid. I used signal opacityNeedsReset() and signal digitHasChanged() and connected them to slots in the subobject. The plasmoid seems to work as expected, and bug https://bugs.kde.org/show_bug.cgi?id=353090 is fixed.

mart accepted this revision.Feb 9 2016, 11:21 AM

mart added a reviewer: mart.

This revision is now accepted and ready to land.Feb 9 2016, 11:21 AM

Closed by commit R114:10c489b6b90b: Refactor timer plasmoid (authored by abrahams). · Explain WhyFeb 11 2016, 3:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	applets/timer/package/contents/ui/TimerView.qml (194 lines)
A	M	applets/timer/package/contents/ui/main.qml (165 lines)
D	M	applets/timer/package/contents/ui/timer.qml (312 lines)
M		applets/timer/package/metadata.desktop (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2029	f8af0b5		Jan 20 2016, 4:25 AM	★	★
Diff 2	2030	f8af0b5	Update copyright year	Jan 20 2016, 4:27 AM	★	★
Diff 3	2282	0efcec1	rKDEPLASMAADDONS10c489b6b90bed1253451ae4fb4df241c3657336	Feb 11 2016, 3:17 AM	★	★