Differential D841

Kexi: Make combo box popups for tabular view fit in the current screen
ClosedPublic
Actions

Authored by staniek on Jan 19 2016, 8:30 PM.

Details

Reviewers
piggz
Commits
R8:9082f8068824: Kexi: Make combo box popups for tabular view fit in the current screen
Summary

BUG:357682
FIXED-IN:2.9.11

Test Plan

Try a table and form with combo boxes, pop up near the screen borders and on other screens than 1st

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
staniek updated this revision to Diff 2019.Jan 19 2016, 8:30 PM
staniek retitled this revision from to Kexi: Make combo box popups for tabular view fit in the current screen.
staniek updated this object.
staniek edited the test plan for this revision. (Show Details)
staniek added a reviewer: piggz.
staniek added a subscriber: Kexi-Devel-list.
piggz accepted this revision.Jan 19 2016, 9:18 PM
piggz edited edge metadata.

is all this complexity necessary? seems like the kind of behaviour Qt should handle all on its own!

This revision is now accepted and ready to land.Jan 19 2016, 9:18 PM
staniek added a comment.Jan 19 2016, 9:25 PM
In D841#16137, @piggz wrote:

is all this complexity necessary? seems like the kind of behaviour Qt should handle all on its own!

Yes it should and it does but in private sub-widgets such as QComboBox's popup. We have no access to its API, at least not in a way that fits to our custom delegate-based Table View.

I also tried to move this logic to KexiUtils but gave up: it becomes complex.

Closed by commit R8:9082f8068824: Kexi: Make combo box popups for tabular view fit in the current screen (authored by staniek). · Explain WhyJan 19 2016, 9:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2023

View Options

kexi/widget/tableview/kexicomboboxbase.cpp

Loading...
View Options

kexi/widget/tableview/kexicomboboxpopup.cpp

Loading...