Remove check for SNI hosts when chosing
AbandonedPublic

Authored by davidedmundson on Oct 18 2017, 10:04 AM.

Details

Reviewers
None
Summary

Previous code (since very first commit) checked for both having a valid
KSNI watcher as well as making sure there was a host available in order
to choose which mode to use.

This made some sense when Plasma 4 still had proper xembed support and
one could turn SNIs off.

The current code here is broken. On first creation we only check for a
watcher - and only ends up checking for the host after it changes at
runtime.

Given it's not working properly, and the use case has changed it seems
we can safely remove it.

This removes a blocking DBus call on the property.

Diff Detail

Repository
R289 KNotifications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 18 2017, 10:04 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
davidedmundson abandoned this revision.Oct 18 2017, 10:05 AM

arc sent this twice for some reason.