Details

Reviewers

Commits

R33:92328461ac04: Added possibility to filter problems based on Severities independently
R32:92328461ac04: Added possibility to filter problems based on Severities independently

Summary

Introduced Severities QFlag
Allow setting severities individually in problemmodel, problemstore, filteredproblemstore
Added testSeverities() to test_problemstore.cpp Problem Reporter plugin
Added testing of setSeverities to test_problemmodel.cpp
Added testing of setSeverities to test_filteredproblemstore.cpp
Added problems to test_filteredproblemstore.cpp
Changed problemtreeview.cpp to use the new setSeverities function
Changed from ProblemStore to FilteredProblemStore in probleemreportermodel.cpp

Test Plan

Seams to work on the kdevplatform project (I imported the git repository of kdevplatform to kdevelop, it showed my many errors and warnings as I haven't configured anything).
The new unit tests pass.

Diff Detail

Repository

R33 KDevPlatform

Branch

problem_tool_filtering

Lint

No Linters Available

Unit

No Unit Test Coverage

apuzio updated this revision to Diff 2004.Jan 18 2016, 7:09 PM

apuzio retitled this revision from to Added possibility to filter problems based on Severity independently.

apuzio updated this object.

apuzio edited the test plan for this revision. (Show Details)

apuzio added a reviewer: kfunk.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 18 2016, 7:09 PM

Fixed bug in problemstore.cpp

apuzio updated this object.Jan 18 2016, 7:31 PM

kfunk added inline comments.Jan 19 2016, 12:20 PM

interfaces/iproblem.h
55	Note: Please get rid off that `NoSeverity` again. It's not a valid severity after all.
plugins/problemreporter/problemtreeview.cpp
311	IProblem::NoSeverity``` -> ```IProblem::Severities()

Add debug

FIXED THE PROBLEM (changed from ProblemStore to FilteredProblemStore in probleemreportermodel.cpp)

apuzio marked an inline comment as done.Jan 20 2016, 4:39 PM

apuzio added inline comments.

interfaces/iproblem.h
55–59 ↗	(On Diff #2004)	Severity for some problems is sometimes = 0, so I would keep it for now.

Workaround for problems wothout correctly set severity
Changed comments and moved around code

Small style change
Fixed the dirty hack in test_filteredproblemstore.cpp

apuzio retitled this revision from Added possibility to filter problems based on Severity independently to Added possibility to filter problems based on Severities independently.Jan 20 2016, 5:16 PM

apuzio updated this object.

apuzio edited the test plan for this revision. (Show Details)

Closed by commit R33:92328461ac04: Added possibility to filter problems based on Severities independently (authored by apuzio, committed by kfunk). · Explain WhyJan 26 2016, 10:03 PM

This revision was automatically updated to reflect the committed changes.

kfunk added inline comments.Jan 27 2016, 9:00 AM

shell/problemmodel.h
146–161 ↗	(On Diff #2004)	Btw: Why's that still here? Can we remove? Care to file a patch for that?

apuzio added inline comments.Jan 27 2016, 11:27 AM

shell/problemmodel.h
146–162 ↗	(On Diff #2004)	@kfunk: I can remove the old functions that I left for backward compatibility, if you want.

			Path	Packages
M			interfaces/iproblem.h (11 lines)
M			plugins/problemreporter/problemtreeview.h (8 lines)
M			plugins/problemreporter/problemtreeview.cpp (40 lines)
M			shell/filteredproblemstore.cpp (2 lines)
M			shell/problemmodel.h (17 lines)
M			shell/problemmodel.cpp (6 lines)
M			shell/problemstore.h (22 lines)
M			shell/problemstore.cpp (23 lines)
M			shell/tests/test_filteredproblemstore.cpp (229 lines)
M			shell/tests/test_problemmodel.cpp (77 lines)
M			shell/tests/test_problemstore.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2004	8a6b565		Jan 18 2016, 7:09 PM	★	★
Diff 2	2005	8a6b565	- Fixed bug in problemstore.cpp	Jan 18 2016, 7:26 PM	★	★
Diff 3	2024	8a6b565	- Add debug	Jan 19 2016, 9:34 PM	★	★
Diff 4	2039	8a6b565	FIXED THE PROBLEM (changed from ProblemStore to FilteredProblemStore in probleemreportermodel.cpp)	Jan 20 2016, 4:33 PM	★	★
Diff 5	2040	8a6b565	- Workaround for problems wothout correctly set severity	Jan 20 2016, 4:56 PM	★	★
Diff 6	2041	8a6b565	- Small style change	Jan 20 2016, 5:10 PM	★	★
Diff 7	2110	bec17e1	rKDEVPLATFORM92328461ac04a9ce19b8f738e955142a63471216	Jan 26 2016, 10:02 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
532baa2e34f6	601cceb7c06e	81ab228b9f8f	Artur Puzio	Fixed bug in problemstore.cpp	Jan 18 2016, 7:24 PM
81ab228b9f8f	bf6f95b09ee4	525d8528d429	Artur Puzio	Added testing of setSeverities to test_problemmodel.cpp	Jan 18 2016, 7:07 PM
525d8528d429	8627db4b8f0f	a0f1d0dbcff5	Artur Puzio	Changed problemmodel. Not fully working.	Jan 18 2016, 6:52 PM
a0f1d0dbcff5	ee88abc9df86	542e7961feba	Artur Puzio	Added problems to test_filteredproblemstore.cpp	Jan 17 2016, 10:16 PM
542e7961feba	31b7dc32bd25	988f15b844bd	Artur Puzio	Added testing of setSeverities to test_filteredproblemstore.cpp	Jan 17 2016, 9:58 PM
988f15b844bd	1bc419e0f583	56124ad97630	Artur Puzio	Added testSeverities to test_problemstore.cpp	Jan 17 2016, 5:49 PM
56124ad97630	ed1c38a96558	952f1ae83df1	Artur Puzio	Allow setting severities individually in problemmodel, problemstore… (Show More…)	Jan 17 2016, 3:13 PM
952f1ae83df1	4a7f3c80fad6	8a6b56567677	Artur Puzio	Introduce Severities QFlag	Jan 17 2016, 1:48 PM

Added possibility to filter problems based on Severities independently
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 2005

interfaces/iproblem.h

plugins/problemreporter/problemtreeview.h

plugins/problemreporter/problemtreeview.cpp

shell/filteredproblemstore.cpp

shell/problemmodel.h

shell/problemmodel.cpp

shell/problemstore.h

shell/problemstore.cpp

shell/tests/test_filteredproblemstore.cpp

shell/tests/test_problemmodel.cpp

shell/tests/test_problemstore.cpp

Added possibility to filter problems based on Severities independentlyClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 2005

interfaces/iproblem.h

plugins/problemreporter/problemtreeview.h

plugins/problemreporter/problemtreeview.cpp

shell/filteredproblemstore.cpp

shell/problemmodel.h

shell/problemmodel.cpp

shell/problemstore.h

shell/problemstore.cpp

shell/tests/test_filteredproblemstore.cpp

shell/tests/test_problemmodel.cpp

shell/tests/test_problemstore.cpp

Added possibility to filter problems based on Severities independently
ClosedPublic
Actions

Revision Contents
Changeset List