Differential D8301

Code Cleaning
ClosedPublic
Actions

Authored by rizzitello on Oct 14 2017, 8:20 PM.

Details

Reviewers
laysrodrigues
tcanabrava
Group Reviewers
Atelier: AtCore
Commits
R232:9f2ad7915939: Fix typos in Doxygen comments
R232:5f8bc41cd2f0: Add new line for easier readability
R232:7481038b17db: Remove unneeded semi-colons.
R232:f0bc154d2726: Move include for test object to header to be consistent with other tests
R232:1c99bb402855: Make all the files have consistent include patterns
R232:b5be37cffd65: Code Cleaning
R232:3deea5dc2390: Remove unneeded QDebug include
Summary

Code Cleanup across the following commits,

  • Remove unneeded QDebug include
  • Move include for test object to header to be consistent with other tests
  • Make all the files have consistent include patterns
  • Fix typos in Doxygen comments
  • Remove unneeded semi-colons.
  • Add new line for easier readability

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello created this revision.Oct 14 2017, 8:20 PM
rizzitello edited the summary of this revision. (Show Details)Oct 14 2017, 8:23 PM
rizzitello added a reviewer: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
rizzitello updated this revision to Diff 20762.Oct 14 2017, 8:33 PM
  • Removed more semi colons
laysrodrigues accepted this revision.Oct 14 2017, 9:27 PM
This revision is now accepted and ready to land.Oct 14 2017, 9:27 PM
tcanabrava accepted this revision.Oct 16 2017, 10:46 AM
Closed by commit R232:3deea5dc2390: Remove unneeded QDebug include (authored by rizzitello). · Explain WhyOct 17 2017, 12:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/atcore.cpp (1 line)
Msrc/seriallayer.cpp (1 line)
Mtestclient/main.cpp (1 line)
Mtestclient/mainwindow.cpp (1 line)

Diff 20883

View Options

src/atcore.cpp

Loading...
View Options

src/seriallayer.cpp

Loading...
View Options

testclient/main.cpp

Loading...
View Options

testclient/mainwindow.cpp

Loading...