Differential D8294

Improve layout in previewer
ClosedPublic
Actions

Authored by rthomsen on Oct 14 2017, 1:46 PM.

Tags

Subscribers

kde-utils-devel, Ark

Details

Reviewers

elvisangelaccio

Commits

R36:f78dc3357284: Improve layout of internal previewer

Summary

Move mimetype icon an comment to below the KPart.
Reduce icon size of mimetype icon.
Remove some margins.

Before:

After:

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rthomsen created this revision.Oct 14 2017, 1:46 PM

Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald TranscriptOct 14 2017, 1:46 PM

rthomsen edited the summary of this revision. (Show Details)Oct 14 2017, 2:00 PM

rthomsen retitled this revision from Improve spacing in previewer to Improve layout in previewer.Oct 14 2017, 2:04 PM

elvisangelaccio added inline comments.Oct 14 2017, 2:13 PM

part/arkviewer.cpp
175	Why hardcoding the size? I get 16 with `KIconLoader::Small`

Don't hardcode icon sizes.

rthomsen marked an inline comment as done.Oct 14 2017, 2:18 PM

rthomsen added inline comments.

part/arkviewer.cpp
175	Is it ok to hardcode these sizes?

elvisangelaccio accepted this revision.Oct 14 2017, 2:20 PM

This revision is now accepted and ready to land.Oct 14 2017, 2:20 PM

Closed by commit R36:f78dc3357284: Improve layout of internal previewer (authored by rthomsen). · Explain WhyOct 14 2017, 2:25 PM

This revision was automatically updated to reflect the committed changes.

rthomsen mentioned this in R36:f78dc3357284: Improve layout of internal previewer.

Revision Contents
Changeset List

			Path	Packages
M			part/arkviewer.cpp (2 lines)
M			part/arkviewer.ui (47 lines)

Diff 20736

part/arkviewer.cpp

Loading...

part/arkviewer.ui

Loading...