Fix Kexi/CalligraDB: Switching off the visibility of query fields hides data in the last field
ClosedPublic
Actions

Authored by staniek on Jan 16 2016, 10:54 PM.

Details

Reviewers

piggz
wicik

Commits

R8:04017e15d00b: Fix Kexi/CalligraDB: Switching off the visibility of query fields hides data…

Summary

This is a fix for Query Designer with SQLite/MySQL/PostreSQL/Sybase.

See https://bugs.kde.org/attachment.cgi?id=96684 test file
BUG:346839
FIXED-IN:2.9.11

Test Plan

Try the minimal example from https://bugs.kde.org/attachment.cgi?id=96684, open query1 in design mode, set Visible=off for id and a fields, switch to data view.
Field b has data loaded after this fix.

Diff Detail

Repository

R8 Calligra

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

staniek updated this revision to Diff 1987.Jan 16 2016, 10:54 PM

staniek retitled this revision from to Fix Kexi: Switching off the visibility of query fields hides data in the last field.

staniek updated this object.

staniek edited the test plan for this revision. (Show Details)

staniek added a reviewer: piggz.

staniek added a subscriber: Kexi-Devel-list.

staniek added a project: KEXI.Jan 16 2016, 10:54 PM

Added the same fix for MySQL

staniek updated this object.Jan 17 2016, 7:41 PM

staniek added a reviewer: wicik.Jan 17 2016, 8:14 PM

Solid fix for CalligraDB (cached vector of visible columns introduced)
pqxx/sybase driver fix and more complete fixes for other drivers

Done with updates, please test...

piggz accepted this revision.Jan 19 2016, 9:12 PM

piggz edited edge metadata.

This revision is now accepted and ready to land.Jan 19 2016, 9:12 PM

Closed by commit R8:04017e15d00b: Fix Kexi/CalligraDB: Switching off the visibility of query fields hides data… (authored by staniek). · Explain WhyJan 19 2016, 9:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kexi/kexidb/drivers/mysql/mysqlcursor.cpp (24 lines)
M			kexi/kexidb/drivers/pqxx/pqxxcursor.cpp (5 lines)
M			kexi/kexidb/drivers/sybase/sybasecursor.cpp (10 lines)
M			libs/db/cursor.h (4 lines)
M			libs/db/cursor.cpp (14 lines)
M			libs/db/drivers/sqlite/sqlitecursor.cpp (24 lines)
M			libs/db/queryschema.h (16 lines)
M			libs/db/queryschema.cpp (48 lines)
M			libs/db/queryschema_p.h (11 lines)
M			libs/db/queryschema_p.cpp (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1987	ad9c5c7		Jan 16 2016, 10:54 PM	★	★
Diff 2	1993			Jan 17 2016, 7:40 PM	★	★
Diff 3	1996			Jan 18 2016, 12:35 AM	★	★
Diff 4	2022	b9ef3bd	Commit rCALLIGRA04017e15d00ba770cf82f9afc3f2d7de292468ea	Jan 19 2016, 8:51 PM	★	★