Allow user to access filter configuration xml directly.
ClosedPublic

Authored by woltherav on Oct 11 2017, 2:59 PM.

Details

Summary

This is a bit of an odd feature that I thought might be useful based on me observing my sister and her husband trying to match up filters between two different pcs.

This feature allows users to get the XML of the filterconfiguration directly, and thus allows them to edit the values directly, or more importantly, copy paste filters via text based media for working with teams, or just for sharing their favourite filter configurations.

So this will allow...

  1. Users sharing filters in a team production.
  2. Users sharing favourite filters as we store bookmarked filters in the kritarc, and thus everytime the configuration is reset, filter configs are lost.
  3. Help users with determining how to make python InfoObjects for filters.
Test Plan

It builds and runs.

I checked against the following:

  1. Whether it gives the right config.
  2. Whether it uses the changes made.
  3. What it does with filters like invert.(I disabled it for that)
  4. What happens if the filter is edited wrongly(It checks whether it makes a legal configuration object to avoid crashes).

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
woltherav created this revision.Oct 11 2017, 2:59 PM
rempt accepted this revision.Oct 12 2017, 8:30 AM
rempt added a subscriber: rempt.

I'd make the minimum size of the dialog a bit bigger, and later on we should sytax-highlight the xml, but it's a nice new feature, and pretty useful.

This revision is now accepted and ready to land.Oct 12 2017, 8:30 AM
This revision was automatically updated to reflect the committed changes.