Enable browser widget adding WebEngineWidgets dependency

Authored by dkardarakos on Oct 10 2017, 12:25 PM.



Looking into commit history we figured out that browser widget is disabled due to difficulties using khtml in Windows platform. Since browser widget is quite usable for user translation workflows, we opted for enabling it again using QtWebEngineWidgets/QWebEngineView.

Test Plan

In editor, enable "Internet" widget
Select a cell containing a valid entry
Click Lookup Current or select Follow Table

Diff Detail

R340 Parley
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
dkardarakos created this revision.Oct 10 2017, 12:25 PM
apol added a subscriber: apol.Oct 10 2017, 10:40 PM

Then KHtml should stop being a dependency, no?

KHtml is not a dependency anymore, after commit https://cgit.kde.org/parley.git/commit/?id=38c4620041486483449a13a0237c4042c852e41d. Since it is not needed by browser widget as per QWebEngineView approach, from my viewpoint, parley may carry on without such a dependency.

apol accepted this revision.Oct 11 2017, 12:02 PM

Right, I'm sorry.

The patch makes sense. Thanks!

If you need us to the patch, please give us your e-mail.

This revision is now accepted and ready to land.Oct 11 2017, 12:02 PM

No prob Aleix :) I ll take care of the commit in a couple of hours!

This revision was automatically updated to reflect the committed changes.