Differential D8221

keyboard navigation in systemsettings
ClosedPublic
Actions

Authored by mart on Oct 9 2017, 1:27 PM.

Details

Reviewers

None

Group Reviewers

Plasma

Commits

R124:1b904566ba66: keyboard navigation in systemsettings

Summary

correct keyboard navigation in systemsettings, since there is a mix
of qwidgets and QQuickWidgets, when a QQW takes focus, then the
focus chain in the keyboard navigation should traverse it, then go
put of it and focus the next widget, being a normal qwidget or another
qqw in which case the same hack applies

Test Plan

navigating in and out the sidebar and the intro page works

QML based kcms are still not managed, they will need a similar thing

Diff Detail

Repository

R124 System Settings

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mart created this revision.Oct 9 2017, 1:27 PM

Restricted Application added a project: Plasma. · View Herald TranscriptOct 9 2017, 1:27 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart added a reviewer: Plasma.Oct 9 2017, 1:27 PM

activate items on space, enter and return

davidedmundson added a subscriber: davidedmundson.Oct 17 2017, 8:02 AM

davidedmundson added inline comments.

sidebar/SidebarMode.cpp
515	either rootObject()->metaObject()->method("")->invoke(); or QMetaObject::invoke() getting the right object to call a static method on isn't worth it.
sidebar/package/contents/ui/IntroIcon.qml
41	why 4? Is this the item.children count?

some hacks to improve keyboard navigation for QQuickWidget
focus search field on startup
Merge branch 'master' into randa/accessibility
some keybaord navigation fixes
correctly navigate between the two QQuickWidgets
proper metaobject invocation

Closed by commit R124:1b904566ba66: keyboard navigation in systemsettings (authored by mart). · Explain WhyOct 17 2017, 8:38 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			sidebar/SidebarMode.h (12 lines)
M			sidebar/SidebarMode.cpp (52 lines)
M			sidebar/package/contents/ui/CategoriesPage.qml (28 lines)
M			sidebar/package/contents/ui/IntroIcon.qml (33 lines)
M			sidebar/package/contents/ui/SubCategoryPage.qml (25 lines)
M			sidebar/package/contents/ui/introPage.qml (13 lines)
M			sidebar/package/contents/ui/main.qml (13 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20516	31faf1e		Oct 9 2017, 1:27 PM	★	★
Diff 2	20518	c59cb9b	- activate items on space, enter and return	Oct 9 2017, 2:28 PM	★	★
Diff 3	20892	84b58d3	- some hacks to improve keyboard navigation for QQuickWidget	Oct 17 2017, 8:28 AM	★	★
Diff 4	20893	cfbc64d	R124:1b904566ba6635a819b7b5f66d5a2a8dc480aacc	Oct 17 2017, 8:37 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
d6c514206129	a0752781a337	d0bef87ef91b	Marco Martin	proper metaobject invocation (Show More…)	Oct 17 2017, 8:26 AM
d0bef87ef91b	e2adab0e4e5a	c59cb9b7fe20	Marco Martin	correctly navigate between the two QQuickWidgets	Oct 9 2017, 1:20 PM
c59cb9b7fe20	cb5b6c1ca1bb	08e04a6a700d	Marco Martin	some keybaord navigation fixes	Oct 9 2017, 12:16 PM
08e04a6a700d	49b2b4886eae	2739ddb44ecc 31faf1e7ebfe	Marco Martin	Merge branch 'master' into randa/accessibility	Oct 9 2017, 12:06 PM
31faf1e7ebfe	d73c76ca7eda	f167339c12c0	Marco Martin	slightly larger columns	Sep 27 2017, 12:10 PM
f167339c12c0	8031c5667fcc	a4559890b40a	Marco Martin	get rid of binding loop	Oct 6 2017, 12:30 PM
a4559890b40a	798912ea150c	853e42545e5d	l10n daemon script	SVN_SILENT made messages (.desktop file) - always resolve ours (Show More…)	Oct 6 2017, 3:08 AM
853e42545e5d	d7c27e76cca6	987e2c204bd0	l10n daemon script	SVN_SILENT made messages (.desktop file) - always resolve ours (Show More…)	Oct 5 2017, 3:17 AM
987e2c204bd0	3cd0b487ae0c	c64eb56512f9	Marco Martin	align perfectly the headers of the two columns	Oct 4 2017, 4:48 PM
c64eb56512f9	4e43c343fe38	1cdc39421066 e38a0d028044	David Faure	Merge branch 'Plasma/5.11'	Oct 4 2017, 8:23 AM
e38a0d028044	71d3aa59da55	acc6a025ec11	David Faure	Remove unnecessary remove_definitions()	Oct 4 2017, 8:23 AM
acc6a025ec11	ebdf7bcf2f41	f32288faa248	David Faure	Define -DQT_NO_URL_CAST_FROM_STRING and fix compilation. (Show More…)	Oct 4 2017, 8:20 AM
1cdc39421066	cb2a7bd454dc	29259ef7c62d	Marco Martin	better placing for tooltips (Show More…)	Sep 27 2017, 9:41 AM
29259ef7c62d	9b55174dce7e	6882f2a1fcfd	Marco Martin	hide tooltip on mouse leave (Show More…)	Sep 27 2017, 9:33 AM
f32288faa248	34798b54db87	0af6923c3800	l10n daemon script	SVN_SILENT made messages (.desktop file) - always resolve ours (Show More…)	Sep 18 2017, 4:31 AM
6882f2a1fcfd	f7a3a112d26d	906a8233fcb6	l10n daemon script	SVN_SILENT made messages (.desktop file) - always resolve ours (Show More…)	Sep 18 2017, 3:04 AM
0af6923c3800	fc934f6f7b57	2449b31fb825	l10n daemon script	SVN_SILENT made messages (.desktop file) - always resolve ours (Show More…)	Sep 16 2017, 4:54 AM
906a8233fcb6	c2cb0663fb57	099f6e546a6a	l10n daemon script	SVN_SILENT made messages (.desktop file) - always resolve ours (Show More…)	Sep 16 2017, 3:10 AM
099f6e546a6a	53f14a9d15af	84b58d3e92f4	l10n daemon script	SVN_SILENT made messages (.desktop file) - always resolve ours (Show More…)	Sep 15 2017, 3:14 AM
2739ddb44ecc	59ed0714ea65	2310ac9c7a1d	Marco Martin	focus search field on startup	Sep 14 2017, 8:57 PM
2310ac9c7a1d	22696f926c68	1fe498489e4b	Marco Martin	some hacks to improve keyboard navigation for QQuickWidget	Sep 14 2017, 1:06 PM