| knauss |
This now considers two additional attributes:
This became necessary with the fairly aggressive syntax highlighting
plugin also triggering on vcard or ical attachments. Their plugins now
have priority, as their mimetypes are more specific than text/plain the
highlighting plugin is registered for.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| messageviewer/src/messagepartthemes/default/messagepartrendererfactory.cpp | ||
|---|---|---|
| 157 | return true, because, if this is empty there is no mimetype set. | |
| messageviewer/src/messagepartthemes/default/messagepartrendererfactory.cpp | ||
|---|---|---|
| 157 | That would require all plugins (and all internal renderers) to actually specify a mimetype. That is not currently the case, so we treat that as a renderer that can handle any mimetype, and thus also with the lowest priority, as its most generic. For those having a 1:1 mapping to custom part types that is perfectly fine, no need for a mimetype there anyway. | |
| messageviewer/src/messagepartthemes/default/messagepartrendererfactory.cpp | ||
|---|---|---|
| 157 | ah okay this loop kicks out all elements that result with true. I first read it like, only elementents that result true will be keeped in the list. | |