Differential D8162

Attachment open confirmation dialogue: Show icons on buttons
ClosedPublic
Actions

Authored by marten on Oct 6 2017, 5:54 PM.

Details

Reviewers
vkrause
Group Reviewers
KDE PIM
Commits
R94:f8e92954a092: Attachment open confirmation dialogue: Show icons on buttons
Summary

This change shows theme icons on the "Open With..." button (the standard "document-open" icon) and on the "Open with 'application'" button (the application's icon as defined in its service file). These buttons previously had no icons, but the other two in the dialogue did so unbalancing the appearance.

The dialogue text is converted to KUIT markup.

This requires passing the service 'offer' to AttachmentDialog::AttachmentDialog(), instead of the application name.

Test Plan

Built messagelib with this change, checked for correct operation and appearance of the dialogue in KMail.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
marten created this revision.Oct 6 2017, 5:54 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 6 2017, 5:54 PM
vkrause accepted this revision.Oct 7 2017, 8:22 AM
This revision is now accepted and ready to land.Oct 7 2017, 8:22 AM
Closed by commit R94:f8e92954a092: Attachment open confirmation dialogue: Show icons on buttons (authored by marten). · Explain WhyOct 7 2017, 8:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20455

View Options

messageviewer/src/viewer/viewer_p.cpp

Loading...
View Options

messageviewer/src/widgets/attachmentdialog.h

Loading...
View Options

messageviewer/src/widgets/attachmentdialog.cpp

Loading...