Differential D8133

Fix cancelTask() for retrieveItems()
ClosedPublic
Actions

Authored by nowicki on Oct 4 2017, 5:38 AM.

Details

Reviewers
mlaurent
dvratil
Group Reviewers
KDE PIM
Commits
R165:b5f34f2abab0: Fix cancelTask() for retrieveItems()
Summary

Terminate the current transaction similar to the retrieveItem() case as otherwise the state machine is broken.

I've seen this screw up the EWS resource a few times when item retrieval from the server fails for some reason.

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nowicki created this revision.Oct 4 2017, 5:38 AM
dvratil accepted this revision.Oct 4 2017, 11:07 AM

Good catch! Commit to Applications/17.08 branch please.

This revision is now accepted and ready to land.Oct 4 2017, 11:07 AM
nowicki added a comment.Oct 4 2017, 12:05 PM
In D8133#152246, @dvratil wrote:

Good catch! Commit to Applications/17.08 branch please.

Only to 17.08 or 17.08 + master?

dvratil added a comment.Oct 4 2017, 12:07 PM

Commit to 17.08, and merge into master. If there are merge conflicts or other issues, just let it be, I'll merge it later.

Closed by commit R165:b5f34f2abab0: Fix cancelTask() for retrieveItems() (authored by nowicki). · Explain WhyOct 4 2017, 12:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/agentbase/resourcebase.cpp (3 lines)

Diff 20341

View Options

src/agentbase/resourcebase.cpp

Loading...