Add a Grantlee callback tag for nesting templates
ClosedPublic
Actions

Authored by vkrause on Oct 3 2017, 3:26 PM.

Details

Reviewers

knauss

Commits

Summary

This allows us to write continuously to one single stream rather than
buffering the nested content first.

So far only used for encapsulated messages, all other usages have yet to
be ported.

Repository

R94 PIM: Message Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

Port signed/encrypted rendering to use the callback mechanism.

messageviewer/src/messagepartthemes/default/messagepartrenderermanager.cpp
109	why messagevier and not also into libmessageviewer? I think it is better to have everything in the same directory.

messageviewer/src/messagepartthemes/default/messagepartrenderermanager.cpp
109	I agree on having everything in the same place of course. This specific file ends up in the plugin install dir, we are currently using "messageviewer" for that. Same for include/ and half of share/. I only see assets of the enterprise style in share/libmessageviewer here. So, that's probably the thing we want to fix.

messageviewer/src/messagepartthemes/default/messagepartrenderermanager.cpp
109	yes that is the better approch to move everything to messageviewer

This revision is now accepted and ready to land.Oct 4 2017, 4:50 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		messageviewer/src/CMakeLists.txt (6 lines)
M		messageviewer/src/messagepartthemes/default/defaultrenderer.cpp (58 lines)
M		messageviewer/src/messagepartthemes/default/messagepartrenderermanager.cpp (3 lines)
M		messageviewer/src/messagepartthemes/default/templates/encapsulatedrfc822messagepart.html (2 lines)
M		messageviewer/src/messagepartthemes/default/templates/encryptedmessagepart.html (2 lines)
M		messageviewer/src/messagepartthemes/default/templates/signedmessagepart.html (2 lines)
A	M	messageviewer/src/messagepartthemes/grantlee/CMakeLists.txt (3 lines)
A	M	messageviewer/src/messagepartthemes/grantlee/grantleeextension.h (60 lines)
A	M	messageviewer/src/messagepartthemes/grantlee/grantleeextension.cpp (68 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20300	cc40a27		Oct 3 2017, 3:26 PM	★	★
Diff 2	20305	30776ba	Port signed/encrypted rendering to use the callback mechanism.	Oct 3 2017, 3:53 PM	★	★
Diff 3	20352	30776ba	R94:599a2275c575938ce68f235a3b2c992056cebfb0	Oct 4 2017, 4:54 PM	★	★