Move WindowRules from Client to AbstractClient
ClosedPublic
Actions

Authored by graesslin on Oct 1 2017, 2:42 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:0372fdaf9275: Move WindowRules from Client to AbstractClient

Summary

So far window rule specific functionality was only implemented in Client
and in ShellClient there was only a dummy implementation. This change
moves the client_rules member variable from Client to AbstractClient.
Areas which would not compile anymore are adjusted.

This is a first step to get window rule support for Wayland windows.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Oct 1 2017, 2:42 PM

Restricted Application added a project: KWin. · View Herald TranscriptOct 1 2017, 2:42 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

I noticed I hadn't removed the variable from Client...

That turned into another round of refactoring and moving things from Client to AbstractClient.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptOct 1 2017, 7:31 PM

graesslin added a dependent revision: D8094: Port RuleBook::discardUsed from Client to AbstractClient.Oct 1 2017, 7:40 PM

davidedmundson accepted this revision.Oct 5 2017, 10:57 PM

This revision is now accepted and ready to land.Oct 5 2017, 10:57 PM

Closed by commit R108:0372fdaf9275: Move WindowRules from Client to AbstractClient (authored by graesslin). · Explain WhyOct 7 2017, 5:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			abstract_client.h (17 lines)
M			abstract_client.cpp (21 lines)
M			client.h (21 lines)
M			client.cpp (8 lines)
M			manage.cpp (2 lines)
M			rules.h (8 lines)
M			rules.cpp (36 lines)
M			shell_client.h (4 lines)
M			shell_client.cpp (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20188	2529803		Oct 1 2017, 2:41 PM	★	★
Diff 2	20204	2529803	I noticed I hadn't removed the variable from Client...	Oct 1 2017, 7:31 PM	★	★
Diff 3	20416	07d1cb1	R108:0372fdaf9275bd7ed5401f8c11fe85a050266e7b	Oct 7 2017, 5:42 AM	★	★