Differential D8048

[WinInk] Clip tilt angles to 60 instead of scaling 2/3
ClosedPublic
Actions

Authored by alvinhochun on Sep 28 2017, 9:06 PM.

Details

Reviewers
dkazakov
Group Reviewers
Krita
Maniphest Tasks
T6807: Add Win8+ "Pointer Input Message" support
Commits
R37:55f564dfa548: WinInk: Clip tilt angles to 60 instead of scaling 2/3
R37:ebc8ea3b25b8: WinInk: Clip tilt angles to 60 instead of scaling 2/3
Summary

From testing on my Surface Pro (2017) and getting tablet logs, it seems that the highest raw tilt angle value I can get is 63, instead of the actual range of 90. Therefore it seems to be a better idea to clip the angle to +/-60 instead of attempting to scale the value down by 2/3.

@dkazakov Can you test 3.3 with tablet logging using your intuos and see if you get any tilt angles over 40 (2/3 of 60)?

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alvinhochun created this revision.Sep 28 2017, 9:06 PM
Closed by commit R37:55f564dfa548: WinInk: Clip tilt angles to 60 instead of scaling 2/3 (authored by alvinhochun). · Explain WhyOct 1 2017, 3:13 PM
Closed by commit R37:ebc8ea3b25b8: WinInk: Clip tilt angles to 60 instead of scaling 2/3 (authored by alvinhochun). · Explain Why
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20191

View Options

libs/ui/input/wintab/kis_tablet_support_win8.cpp

Loading...