Differential D8008

[Folder View] Turn MenuHelper into a singleton type
ClosedPublic
Actions

Authored by broulik on Sep 27 2017, 12:38 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:8abee08b0e81: [Folder View] Turn MenuHelper into a singleton type
Summary

It doesn't store any state but just has methods invoked on it.
Now we create only one MenuHelper instead of one per applet.

Test Plan

Sort by menu is still working, actions still show up in context menu and desktop toolbox

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 27 2017, 12:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 27 2017, 12:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Sep 27 2017, 9:43 PM
This revision is now accepted and ready to land.Sep 27 2017, 9:43 PM
Closed by commit R119:8abee08b0e81: [Folder View] Turn MenuHelper into a singleton type (authored by broulik). · Explain WhySep 28 2017, 8:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20019

View Options

containments/desktop/package/contents/ui/FolderViewLayer.qml

Loading...
View Options

containments/desktop/plugins/folder/folderplugin.cpp

Loading...