Differential D7981

cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND
ClosedPublic
Actions

Authored by asturmlechner on Sep 25 2017, 12:52 PM.

Details

Reviewers
sitter
Group Reviewers
Plasma
Restricted Owners Package(Owns No Changed Paths)
Commits
R572:c89d97c65445: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND
Summary

Many packages have KF5DocTools optional, but as soon as a release is
made that assumption is broken. It would be nice for release script
not to contradict behavior of the git version.

Diff Detail

Repository
R572 releaseme
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
asturmlechner created this revision.Sep 25 2017, 12:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 25 2017, 12:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter added a comment.Sep 25 2017, 1:11 PM

This breaks repos which have no find_package call already.

asturmlechner added a comment.Sep 25 2017, 1:17 PM
In D7981#148820, @sitter wrote:

This breaks repos which have no find_package call already.

Fine, I can re-add that without REQUIRED keyword. Out of curiousity, do you know of an example?

asturmlechner updated this revision to Diff 19901.Sep 25 2017, 4:43 PM

Re-added search for KF5DocTools

Owners added a reviewer: Restricted Owners Package.Sep 25 2017, 4:43 PM
asturmlechner edited the summary of this revision. (Show Details)Sep 25 2017, 4:44 PM
sitter accepted this revision.Sep 26 2017, 10:32 AM

I suppose that is fine.

Note that ki18n is also currently marked REQUIRED though.

This revision is now accepted and ready to land.Sep 26 2017, 10:32 AM
asturmlechner added a comment.Oct 1 2017, 2:21 PM
In D7981#149086, @sitter wrote:

Note that ki18n is also currently marked REQUIRED though.

thanks, I'm not concerned about ki18n as I have not seen it being optional anywhere.

asturmlechner closed this revision.Oct 1 2017, 2:23 PM

Revision Contents
Changeset List

PathPackages
Mlib/releaseme/cmakeeditor.rb (2 lines)

Diff 19901

View Options

lib/releaseme/cmakeeditor.rb

Loading...