Differential D7937

Don't reload background contrast effect on screen resize
ClosedPublic
Actions

Authored by davidedmundson on Sep 22 2017, 1:14 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R108:55d219429a54: Don't reload background contrast effect on screen resize
Summary

Similar to the Blur patch. Arguably rven less reason as this doesn't
have a texture the size of the workspace.

We don't need to delete and recreate the entire effect every time the
screen changes; This deletes the wayland global which causes quite a bit
of extra work for the clients.

Test Plan

Changed resolution under X, and scale under wayland
Panel looked the same and nothing exploded

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Sep 22 2017, 1:14 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 22 2017, 1:14 PM
Restricted Application added subscribers: KWin, kwin, plasma-devel. · View Herald Transcript
graesslin added a subscriber: graesslin.Sep 22 2017, 1:32 PM
graesslin added inline comments.
effects/backgroundcontrast/contrast.cpp
87

please no foreach in new code, please use range-based for. (Reason: I don't trust Qt to keep it after there was a prominent blog post about deprecating foreach)

87–88

Please use {}

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptSep 22 2017, 2:27 PM
graesslin accepted this revision.Sep 22 2017, 2:55 PM
This revision is now accepted and ready to land.Sep 22 2017, 2:55 PM
Closed by commit R108:55d219429a54: Don't reload background contrast effect on screen resize (authored by davidedmundson). · Explain WhySep 29 2017, 12:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20088

View Options

effects/backgroundcontrast/contrast.cpp

Loading...