Differential D7932

Fix broken reloading and broken layout changing due to lost filename
ClosedPublic
Actions

Authored by kossebau on Sep 22 2017, 2:24 AM.

Details

Reviewers
ltoscano
kleag
Commits
R491:25d858c6aeb8: Fix broken reloading and broken layout changing due to lost filename
Summary

Fixup for 67489cf6764f53e343d47609ead354388f948a5b

Test Plan

Reload (F5) and changing the layout algorithm no longer results in error
message about not being able to load "".

Diff Detail

Repository
R491 KGraphViewer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Sep 22 2017, 2:24 AM
kossebau added a comment.Sep 22 2017, 2:25 AM

KGraphViewer should get a 2.4.1 emergency release with this in (meh, did no-one do some pre-release feature test coverage run...)

kleag accepted this revision.Sep 26 2017, 7:44 AM

Ship it!

This revision is now accepted and ready to land.Sep 26 2017, 7:44 AM
Closed by commit R491:25d858c6aeb8: Fix broken reloading and broken layout changing due to lost filename (authored by kossebau). · Explain WhySep 26 2017, 1:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/part/dotgraphview.cpp (12 lines)
Msrc/part/loadagraphthread.h (6 lines)

Diff 19938

View Options

src/part/dotgraphview.cpp

Loading...
View Options

src/part/loadagraphthread.h

Loading...