This diff is related to D785. Also, I've provided "BUG" keyword in that diff, so I'm omitting it here.
Details
Details
- Reviewers
kfunk - Commits
- R32:7147f85e9399: Provide support for highlighting crashed threads
same as in D785
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Feel free to add the BUG line here, too.
Note, please write:
... BUG: 123
so commit hooks are able to parse the "BUG" marker in the commit msg
| debuggers/gdb/debugsession.h | ||
|---|---|---|
| 83 | constify | |
| debuggers/gdb/gdbframestackmodel.cpp | ||
| 81–82 | Take care: 'current-thread-id' apparently might be unset. Protect against this below. Maybe group those two together | |
| 87 | Style: No spaces inside (...) Same below | |
| debuggers/gdb/gdbframestackmodel.cpp | ||
|---|---|---|
| 81–85 | Share r["current-thread-id"].toInt() in a var | |
| debuggers/gdb/debugsession.h | ||
|---|---|---|
| 303 | could you please do a minor fixup commit that moves this bool up a few lines below the other bool? That way we shrink the padding space there instead of growing this class. Not that it matters for this class really, but doing it always allows us to run tools on our code to ensure we waste as little space as possible. And you learn something new as well :) Thanks for the contributions! | |
Comment Actions
yes. please rephrase the comment though:
try if the process crashed.
Also, you should probably rename the variable to m_hasCrashed or m_crashDetected.
Comment Actions
LGTM beside that one nitpick
| debuggers/gdb/debugsession.cpp | ||
|---|---|---|
| 776 | Rename the getter accordingly. | |