Add a dedicated X11EventFilter for forwarding property events to the effect system
ClosedPublic
Actions

Authored by graesslin on Sep 16 2017, 5:29 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:0ed609590b75: Add a dedicated X11EventFilter for forwarding property events to the effect…

Summary

So far both Workspace and Toplevel emitted signals for every property
notify event on the root window and the respective Toplevel windows. The
signals were only used in EffectsHandlerImpl to forward to the effect
system in case the property which changed is registered by an effect.

This change introduces a dedicated event filter for this which is only
created in EffectsHandlerImpl in case an X11 connection is available. It
supports a restart of the X11 system.

The signals used so far are removed from Workspace and Toplevel.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Sep 16 2017, 5:29 PM

Restricted Application added a project: KWin. · View Herald TranscriptSep 16 2017, 5:29 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

ping

broulik accepted this revision.Sep 25 2017, 2:03 PM

This revision is now accepted and ready to land.Sep 25 2017, 2:03 PM

Closed by commit R108:0ed609590b75: Add a dedicated X11EventFilter for forwarding property events to the effect… (authored by graesslin). · Explain WhySep 25 2017, 6:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (1 line)
M		effects.h (7 lines)
M		effects.cpp (26 lines)
M		events.cpp (9 lines)
M		toplevel.h (1 line)
A	M	window_property_notify_x11_filter.h (42 lines)
A	M	window_property_notify_x11_filter.cpp (50 lines)
M		workspace.h (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19593	0c6fdee		Sep 16 2017, 5:29 PM	★	★
Diff 2	19915	e492f9e	R108:0ed609590b75fa9fc2e236c3f91fbb39af20503d	Sep 25 2017, 6:36 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
3e2988bebd2e	96fdad8f2653	0c6fdeef2db4	Martin Flöser	Add a dedicated X11EventFilter for forwarding property events to the effect… (Show More…)	Sep 16 2017, 5:25 PM