Differential D7770

[lookandfeel] Fix GLES incompatibilities in UserDelegate shader code
ClosedPublic
Actions

Authored by bruns on Sep 11 2017, 4:50 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Maniphest Tasks
T7071: Fragment shader in UserDelegate.qml is not GLSL/ES compatible, missing precision specifier
Commits
R120:129884c7b02f: [lookandfeel] Fix GLES incompatibilities in UserDelegate shader code
Summary

BUG: 382668

The shader compilation currently fails on GLES with errors like:
"0:6(2): error: No precision specified in this scope for type `vec4'"

GLES requires variable qualifiers like highp/lowp, whereas desktop OpenGL
does not. As QGlShaderProgram adds suitable defines on desktop OpenGL
for these qualifiers, it is safe to add these to a declarations, see:
http://doc.qt.io/qt-5/qglshaderprogram.html#writing-portable-shaders

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Sep 11 2017, 4:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptSep 11 2017, 4:50 PM
davidedmundson accepted this revision.Sep 26 2017, 4:22 PM
This revision is now accepted and ready to land.Sep 26 2017, 4:22 PM
Closed by commit R120:129884c7b02f: [lookandfeel] Fix GLES incompatibilities in UserDelegate shader code (authored by bruns). · Explain WhySep 26 2017, 9:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19956

View Options

lookandfeel/contents/components/UserDelegate.qml

Loading...