[Folder View Icons Config] Fix initial index of ComboBox
ClosedPublic

Authored by broulik on Sep 8 2017, 12:17 PM.

Details

Summary

A while ago I optimized Plasma config dialogs to create the component with the cfg_ properties already set. This code relied on the fact that mode changes initially. Use Component.onCompleted now that we can and also use onActivated which only fires if the index is explicitly changed by the user, not on imperative assignment.

Test Plan

Changed sorting to "Name" or "Size", closed dialog, opened it, was still selected. Previously it would always revert to "Unsorted"

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 8 2017, 12:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 8 2017, 12:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Sep 10 2017, 7:19 AM
This revision is now accepted and ready to land.Sep 10 2017, 7:19 AM
This revision was automatically updated to reflect the committed changes.