Differential D773

NativeAppJob: Base on OutputExecuteJob
ClosedPublic
Actions

Authored by kfunk on Jan 9 2016, 11:23 PM.

Details

Reviewers
mwolff
Summary

Now we get all its features for free + get an additional feature for
free which will be introduced in:

https://phabricator.kde.org/D770

Diff Detail

Repository
R33 KDevPlatform
Lint
No Linters Available
Unit
No Unit Test Coverage
kfunk updated this revision to Diff 1830.Jan 9 2016, 11:23 PM
kfunk retitled this revision from to NativeAppJob: Base on OutputExecuteJob.
kfunk updated this object.
kfunk edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 9 2016, 11:23 PM
kfunk updated this revision to Diff 1831.Jan 9 2016, 11:27 PM

More cleanup

kfunk updated this revision to Diff 1835.Jan 10 2016, 12:07 PM

Remove unrelated hunks

kfunk updated this revision to Diff 1836.Jan 10 2016, 12:09 PM

Try again

kfunk added a comment.EditedJan 10 2016, 12:22 PM

Testing done:

  • Tested starting via terminal
  • Tested normal start
  • Tested killing already-running job
  • Checked the output (*** Started ***, *** Finished ***, etc. markers are still there)

Works fine.

mwolff accepted this revision.Jan 10 2016, 11:05 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

lgtm, lots of code removed, always a good sign :)

This revision is now accepted and ready to land.Jan 10 2016, 11:05 PM
kfunk closed this revision.Jan 10 2016, 11:50 PM

commit 49f32330fa15b4bfd93bba5e63375cb200813b00
Author: Kevin Funk <kfunk@kde.org>
Date: Sun Jan 10 00:20:55 2016 +0100

NativeAppJob: Base on OutputExecuteJob

Now we get all its features for free + get an additional feature for
free which will be introduced in:
  https://phabricator.kde.org/D770

Revision Contents
Changeset List

Diff 1836

View Options

plugins/execute/nativeappjob.h

Loading...
View Options

plugins/execute/nativeappjob.cpp

Loading...